Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Not possible to disable an included module in a layout #8880

Closed
eki89 opened this issue May 16, 2018 · 7 comments
Closed

Not possible to disable an included module in a layout #8880

eki89 opened this issue May 16, 2018 · 7 comments
Labels

Comments

@eki89
Copy link

eki89 commented May 16, 2018

Hey everyone,

i have just seen that it is not possible to disable/enable an included frontend module in layouts. The visibility toggle buttons switchs to grey, but after a reload of the layout dataset the buttun is still green/enabled. I've checked the requests while pressing the button, but only the svg image is loaded. An AJAX request wont be performed.

@kikmedia
Copy link

Did you save the layout after toggling the icon?

@fritzmg
Copy link
Contributor

fritzmg commented May 16, 2018

I can confirm the issue.

Did you save the layout after toggling the icon?

You shouldn't have to do that, since you do not have to do that anywhere else? Or is it deliberate in this case?

@xchs
Copy link
Contributor

xchs commented May 16, 2018

See the comments in ticket #5558

@fritzmg
Copy link
Contributor

fritzmg commented May 16, 2018

The comments in the ticket don't explain the behaviour though.

@xchs
Copy link
Contributor

xchs commented May 16, 2018

Turn off JavaScript and you will see the difference ;)

The enable/disable toggle in the page layout is implemented with a checkbox (hidden when JavaScript is on) and gets triggered by the eye icon. The status of all other visibility togglers is written directly to the database though.

@fritzmg
Copy link
Contributor

fritzmg commented May 16, 2018

Ah ok :). Still a little unintuitive though.

@leofeyer
Copy link
Member

Did you save the layout after toggling the icon?

You shouldn't have to do that, since you do not have to do that anywhere else? Or is it deliberate in this case?

You have to.

Still a little unintuitive though.

True.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants