Add support multiple image formats in pictures #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the use case for this? I understand what the code does, but when would I typically need this? |
|
The use case is that we'll be able to automatically generate e.g. <picture>
<source type="image/webp" srcset="assets/images/pic.webp">
<img src="assets/images/pic.jpg">
</picture>In other words: it's a major performance feature as we can let the browser decide if it understands more modern image formats and if so, select this instead of the bigger (in bytes) one. |
|
And it will then make SEO rating tools like PageSpeed and co. very, very happy. |
leofeyer
pushed a commit
to contao/contao
that referenced
this pull request
Jul 5, 2019
Description ----------- Depends on contao/image#53 Related: php-imagine/Imagine#718 As @Toflar pointed out in contao/image#53 (comment) this feature makes it possible to automatically generate WEBP images. I didn’t add `webp` to the default `contao.image.valid_extensions` configuration because not all plattforms support it. If someone wants to use this feature they need to add `webp` to the valid extensions in their *config.yml*. Commits ------- 1b6ec2a Add support for image format conversion 271a98a Show help message if WEBP is not enabled c67f82f Use 1.0.0-beta3 version of contao/image c094d19 Fix tests 4631a2b Fix PHPStan issues 7465bcc Add formats to predifined sizes configuration f71cd1e Fix image and picture tests f3866e3 Fix PHPStan issues b9fe888 Fix PHPStan issues efe0c65 Fix the coding style 61accc2 Don’t use JSON for the formats option a6cf0a9 Fix the coding style
leofeyer
pushed a commit
to contao/core-bundle
that referenced
this pull request
Jul 5, 2019
Description ----------- Depends on contao/image#53 Related: php-imagine/Imagine#718 As @Toflar pointed out in contao/image#53 (comment) this feature makes it possible to automatically generate WEBP images. I didn’t add `webp` to the default `contao.image.valid_extensions` configuration because not all plattforms support it. If someone wants to use this feature they need to add `webp` to the valid extensions in their *config.yml*. Commits ------- 1b6ec2ac Add support for image format conversion 271a98af Show help message if WEBP is not enabled c67f82fe Use 1.0.0-beta3 version of contao/image c094d193 Fix tests 4631a2b0 Fix PHPStan issues 7465bcc3 Add formats to predifined sizes configuration f71cd1e3 Fix image and picture tests f3866e34 Fix PHPStan issues b9fe8884 Fix PHPStan issues efe0c653 Fix the coding style 61accc28 Don’t use JSON for the formats option a6cf0a9a Fix the coding style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the possibility to use mutiple image formats and convert them automatically.
Examples:
Related: php-imagine/Imagine#718