Handle JSON errors when decoding #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ausi
reviewed
Mar 12, 2020
Comment on lines
205
to
207
| if (!\is_array($content)) { | ||
| throw new \RuntimeException('Invalid JSON: '.json_last_error_msg()); | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (!\is_array($content)) { | |
| throw new \RuntimeException('Invalid JSON: '.json_last_error_msg()); | |
| } | |
| if (JSON_ERROR_NONE !== json_last_error()) { | |
| throw new \JsonException(json_last_error_msg()); | |
| } | |
| if (!\is_array($content)) { | |
| throw new \InvalidArgumentException('Invalid JSON data: expected array, got "%s"', gettype($content))); | |
| } |
How about this?
There was a problem hiding this comment.
JsonException is only available from PHP 7.4 😉
and with 7.4 we could just tell JSON to throw that exception
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes we could, but why would we need different exceptions at all? 🤷♂️
There was a problem hiding this comment.
We are using the polyfill already since #63
|
👍 |
ausi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not sure if we should handle that exception …