Switch to Symfony's version of the Path helper #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ausi
reviewed
Jan 18, 2022
Co-authored-by: Martin Auswöger <martin@auswoeger.com>
ausi
approved these changes
Jan 18, 2022
|
Before merging this we need to make contao 4.9 compatible with symfony/filesystem 5.4 as discussed in #86 (comment) |
|
|
For the record contao/contao#3966 was merged, so the next 4.9 release will be compatible with the changes from this PR. |
leofeyer
approved these changes
Jan 19, 2022
|
Thank you @m-vo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #86
This PR requires
symfony/filesystemin version 5.4 and drops the abandonedwebmozart/path-util. This effectively enforces at least PHP 7.2, so I dropped the 7.1 runs from the CI and updated our PHP requirement as well.I also refactored the usage of string concatenation to
Path::join()calls in ebcf662 and 4ca666d.