Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set basic Contao config in parameters.yml #7

Closed
aschempp opened this issue Nov 25, 2016 · 9 comments
Closed

Allow to set basic Contao config in parameters.yml #7

aschempp opened this issue Nov 25, 2016 · 9 comments
Assignees
Labels

Comments

@aschempp
Copy link
Member

As long as the Contao Manager does not have config options, it is currently not possible to configure things like prepend_local. We should add them to the parameters.yml which is the only file that can be customized per installation.

The only other option would be for everyone to write a ContaoManagerPlugin, which is a bit over-engineered 😂

@aschempp aschempp added this to the 1.1.0 milestone Nov 25, 2016
@aschempp aschempp self-assigned this Nov 25, 2016
@leofeyer
Copy link
Member

leofeyer commented Jan 12, 2017

What about adding an empty app/config/config.yml file by default, which the user can adjust to their needs? Similar to the web/.htaccess file.

@aschempp
Copy link
Member Author

aschempp commented Jan 13, 2017

I just had a thought about this. You can simply set whatever you want in the parameters.yml, right? You can also set contao.prepend_local in there? The parameters.yml is nothing else than a regular configuration file.

@leofeyer
Copy link
Member

I guess so. The difference is that the parameters.yml file might be generated/overwritten by the install tool and then all the custom settings are gone. Therefore I'd prefer to have a config.yml file.

@aschempp
Copy link
Member Author

aschempp commented Jan 13, 2017 via email

@leofeyer
Copy link
Member

Yeah, we might be able to preserve the existing stuff, but it is still bad design IMO.

  • You cannot keep any comments, which someone might have made in their custom config.
  • You should never auto-generate a file that is also meant to be edited by the user.

Technically, Symfony could use only one big parameters.yml file, too, but they are not for good reasons.

@leofeyer
Copy link
Member

leofeyer commented Jan 13, 2017

Then again, it is a managed edition and the users are not supposed to edit config files at all but use the GUI instead. So we do not need a config.yml I guess.

Actually, we do not even need the app folder, do we? We might as well store the parameters.yml file somewhere else.

@aschempp
Copy link
Member Author

aschempp commented Jan 13, 2017 via email

@leofeyer
Copy link
Member

leofeyer commented Jan 13, 2017

Removing the app folder does not work, because then realpath() cannot resolve "%kernel.root_dir%/..web" in Symfony anymore. 😄

Ok, so:

  1. If we explicitly support editing config files, I'd prefer a config.yml file.
  2. Otherwise I'm fine with dumping everything into the parameters.yml file.

@aschempp
Copy link
Member Author

Thanks to 5477fda and 62a4abe the same parameters are now available as in our standard edition, though they don't need to be configured for the application to work.

Added import of app/config/config.yml in 804f1d6

@aschempp aschempp removed this from the 1.1.0 milestone Jan 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants