Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using a parameter in the Content-Type header #2

Open
e0ipso opened this issue Aug 14, 2017 · 0 comments
Open

Consider using a parameter in the Content-Type header #2

e0ipso opened this issue Aug 14, 2017 · 0 comments

Comments

@e0ipso
Copy link
Member

e0ipso commented Aug 14, 2017

$event->getResponse()->headers->set('X-Drupal-ApiVersion', $this->apiVersionCalculator->getApiVersion()->toSemanticString());

If we use a parameter in the content type header: Content-Type: application/vnd.api+json; version=2.9.18 then we don't have to worry about adding X-Drupal-ApiVersion to the Vary header to support cache variations (even then the support of Vary is not great).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant