Skip to content
This repository has been archived by the owner on Apr 17, 2024. It is now read-only.

Add an developer and a editor role #57

Closed
dawehner opened this issue Jun 19, 2017 · 8 comments
Closed

Add an developer and a editor role #57

dawehner opened this issue Jun 19, 2017 · 8 comments

Comments

@dawehner
Copy link
Member

dawehner commented Jun 19, 2017

It would be nice to have a role for editors as well as one role for developers.

What kind of permissions should each of those actually have?

@dawehner
Copy link
Member Author

Potential follow up generate some example users

@e0ipso
Copy link
Member

e0ipso commented Jun 20, 2017

I think it would be a good idea to converge on the same roles Reservoir creates with the same permissions (we'll have more than them because there are more features to grant permissions to).

Roles list

  • Anonymous user
  • Authenticated user
  • Content administrator
  • Client developer

@e0ipso
Copy link
Member

e0ipso commented Jun 20, 2017

This was addressed by 076222c. I'm leaving this open in case you want to change the permissions set. I got the permission list from Reservoir.

@wimleers
Copy link
Contributor

  • You committed uuids as well in the config. You don't want that :)
  • Interesting that you're also adding actions. Can you explain why?
  • Finally: do you like the user role labels? Content administrator and Client developer? Would you have chosen different role labels?

@dawehner
Copy link
Member Author

You committed uuids as well in the config. You don't want that :)

As someone who is using Drupal in the wild, I can say the patch provided by alexpott in https://www.drupal.org/node/2788777 totally makes this possible. It allows you to use drush cex with install profiles basically.

Interesting that you're also adding actions. Can you explain why?

This happens when you drush cex :) To be honest though we REALLY don't need them IMHO.

Finally: do you like the user role labels? Content administrator and Client developer? Would you have chosen different role labels?

For me at least "administrator" feels like something with more capabilities. What about "content editor"?

@e0ipso
Copy link
Member

e0ipso commented Jun 21, 2017

Finally: do you like the user role labels? Content administrator and Client developer? Would you have chosen different role labels?

I just reused what it was there. I don't care all that much, i figured that we can change them later. :-P

You committed uuids as well in the config. You don't want that :)

What Daniel said.

Interesting that you're also adding actions. Can you explain why?

We want to have a simple config workflow (it was Alex's only direction). What we want to do is:

  • Click around.
  • drush cex
  • Commit.

Anything more complex than can lead to debugging configuration sets. Not a fun place to be. If that brings in default config that will be created anyways on install, I'm fine with the tradeoff.

@wimleers
Copy link
Contributor

For me at least "administrator" feels like something with more capabilities. What about "content editor"?

But "Content editor" implies more limited capabilities: they can edit content, maybe create new content … but not also publish and manage all content.
That's why I first went with "Content manager". At some point I changed it to "Content administrator".

@e0ipso
Copy link
Member

e0ipso commented Apr 27, 2018

We did this already.

@e0ipso e0ipso closed this as completed Apr 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants