Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualizations #163

Merged
merged 21 commits into from
Jan 13, 2023
Merged

Visualizations #163

merged 21 commits into from
Jan 13, 2023

Conversation

mauricefisher64
Copy link
Collaborator

Changes in this pull request

Improve SDK with new visualizations for tree view of manifest and the ability to dump the certificate chain for the active manifest. Also include the new capability to remove manifests.

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@dkozma
Copy link
Contributor

dkozma commented Dec 15, 2022

@mauricefisher64 Should the tree view be part of c2patool instead of in the main SDK? Or would this be valuable for other apps as well? If so, should visualization be a feature? Just thinking about things like embedded device or web constraints where we want to keep the library as lean as possible.

@mauricefisher64
Copy link
Collaborator Author

@dkozma We have not exposed what I need in the SDK to do treeview in c2patool. The size of the crate is tiny and the source fits on one screen.

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2022

Codecov Report

Merging #163 (13d2fd0) into main (fa2d15a) will increase coverage by 0.06%.
The diff coverage is 81.87%.

@@            Coverage Diff             @@
##             main     #163      +/-   ##
==========================================
+ Coverage   77.53%   77.60%   +0.06%     
==========================================
  Files          68       68              
  Lines       16068    16214     +146     
==========================================
+ Hits        12459    12583     +124     
- Misses       3609     3631      +22     
Impacted Files Coverage Δ
sdk/src/manifest.rs 89.46% <0.00%> (-0.44%) ⬇️
sdk/src/validator.rs 54.54% <ø> (ø)
sdk/src/manifest_store_report.rs 82.23% <79.81%> (-1.98%) ⬇️
sdk/src/store.rs 86.36% <83.33%> (-0.01%) ⬇️
sdk/src/cose_validator.rs 66.70% <93.75%> (+1.41%) ⬆️
sdk/src/claim.rs 83.21% <100.00%> (+0.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@scouten-adobe
Copy link
Collaborator

FWIW I share @dkozma's question about whether this could be done outside the c2pa crate.

When you say, "We have not exposed what I need in the SDK to do treeview in c2patool," my first instinct is to see if we could focus on that first.

I wonder what other innovation we're thwarting by not exposing those same APIs.

@mauricefisher64
Copy link
Collaborator Author

That sounds like a different set of questions and not this PR. We can decide not to add these features until then but I don't see the need for that.

@mauricefisher64 mauricefisher64 merged commit 85e7223 into main Jan 13, 2023
@mauricefisher64 mauricefisher64 deleted the visualizations branch January 13, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants