-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visualizations #163
Visualizations #163
Conversation
…ck_tree_dump # Conflicts: # sdk/src/store.rs
… into hack_tree_dump # Conflicts: # sdk/src/manifest_store_report.rs # sdk/src/store.rs
@mauricefisher64 Should the tree view be part of c2patool instead of in the main SDK? Or would this be valuable for other apps as well? If so, should visualization be a feature? Just thinking about things like embedded device or web constraints where we want to keep the library as lean as possible. |
@dkozma We have not exposed what I need in the SDK to do treeview in c2patool. The size of the crate is tiny and the source fits on one screen. |
Codecov Report
@@ Coverage Diff @@
## main #163 +/- ##
==========================================
+ Coverage 77.53% 77.60% +0.06%
==========================================
Files 68 68
Lines 16068 16214 +146
==========================================
+ Hits 12459 12583 +124
- Misses 3609 3631 +22
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
FWIW I share @dkozma's question about whether this could be done outside the c2pa crate. When you say, "We have not exposed what I need in the SDK to do treeview in c2patool," my first instinct is to see if we could focus on that first. I wonder what other innovation we're thwarting by not exposing those same APIs. |
That sounds like a different set of questions and not this PR. We can decide not to add these features until then but I don't see the need for that. |
Changes in this pull request
Improve SDK with new visualizations for tree view of manifest and the ability to dump the certificate chain for the active manifest. Also include the new capability to remove manifests.
Checklist
TO DO
items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.