Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move swift code into subspec #15

Closed
hfossli opened this issue May 20, 2016 · 6 comments
Closed

Move swift code into subspec #15

hfossli opened this issue May 20, 2016 · 6 comments

Comments

@hfossli
Copy link
Contributor

hfossli commented May 20, 2016

Hi! We love your library! Very nice. The most interesting part in this project for me is the CCBufferedImageDecoder in pair with the library. In my eyes the CCBufferedImageView.swift is more like an example of how to integrate. Therefore I created this https://github.com/agens-no/CCBufferedImageDecoder

Ideally for me we would just change the podspec in this repo to either a) move the swift stuff into a subspec or b) remove the swift stuff or c) use one of the [ports].(https://github.com/ljfantin/Concorde/blob/feature/support_ios_7/Code/CCBufferedImageView.m).

Anyways, just though I should let you know.

@neonichu
Copy link
Contributor

I think it would be fine to move the image view into its own subspec, called "UI" or something like that. If you were considering to submit a PR with that change, I'd be happy to accept it!

@neonichu
Copy link
Contributor

Solved by #16

@hfossli
Copy link
Contributor Author

hfossli commented May 20, 2016

Awesome. I'll delete that repo once the new podspec is public. :)

@hfossli
Copy link
Contributor Author

hfossli commented May 23, 2016

I would highly appreciate if you could publish the new podspec 👍

@neonichu
Copy link
Contributor

Sorry, still dealing with getting the test suite to actually work again with Xcode 7.3.1

@neonichu
Copy link
Contributor

Allright, has been shipped now as 0.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants