-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds additional query syntax for the CDA #49
Merged
floriank
merged 20 commits into
contentful-userland:master
from
floriank:more-complex-queries
Jul 9, 2020
Merged
Adds additional query syntax for the CDA #49
floriank
merged 20 commits into
contentful-userland:master
from
floriank:more-complex-queries
Jul 9, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1822167b055a772b4c6d481759eee4d9baa79915-PR-49
馃挍 - Coveralls |
44e140f
to
8903f5c
Compare
dlitvakb
reviewed
Jul 6, 2020
asaaki
approved these changes
Jul 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks quite good. I'm not a query expert though. 馃槄
Just tiny nits.
for easier tdd
Removes configuration into it's own module, also moves request related functions into it's own `Contentful.Request` module.
Co-authored-by: Christoph Grabo <446613+asaaki@users.noreply.github.com>
Co-authored-by: Christoph Grabo <446613+asaaki@users.noreply.github.com>
c1d7dd3
to
7fa67f1
Compare
..as part of actually writing the officially recognized X-Contentful-User-Agent Header
as proposed by @asaaki
asaaki
approved these changes
Jul 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love it! 馃槏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After having no time for a while these days and thinking a bit about #38, I decided to put in some work about it.
This will add support for more complex queries as noted by @ryansch, in the form of:
and provide some safeguards around it, e.g. using
by
without acontent_type
call is not permitted, etc.Feedback, as always, is very welcome.
TODO
content_type
by
by
, via[nin]
and[in]
by
via[lte]
,[gte]
,[lt]
and[gt]
query
and[match]
Out of scope
Somebody create some issues for the ones above please 馃槈 (will probably do tomorrow)
Fixes #38.