Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request : apps/shopify - add variant name in product select #142

Closed
lexstefan opened this issue Sep 18, 2020 · 5 comments
Closed

request : apps/shopify - add variant name in product select #142

lexstefan opened this issue Sep 18, 2020 · 5 comments

Comments

@lexstefan
Copy link

lexstefan commented Sep 18, 2020

Hello,

I've been testing the shopify app in contentful and I have noticed the products don't have a variant name displayed even tho' the graphQL query has it. Would be nice enough to fix this? Most shops have variants to products, and the product selector has the same product listed 2-3 times when in fact there are 2 to 3 different variants to that product. A regular user would find it difficult to select the correct product variant.

{
    nodes (ids: [${queryIds}]) {
      id,
      ...on ProductVariant {
        sku,
        image {
          src: originalSrc
        },
        title,
        product {
          id,
          title
        }
      }
    }
  }

Thank you!

@cmwall
Copy link

cmwall commented Oct 8, 2020

Having the same issue. It seems like the "SKU" for the product is not actually an SKU or a variant name, but instead a UUID from Shopify.
image

@lexstefan
Copy link
Author

lexstefan commented Oct 9, 2020

I was checking out the apps repository. And apparently the shopify app is using another app to output in the confluent ui. I would have 100% done it and PR it but i haven't had a chance to read up on how to test it. I'll probably have to dedicate some time to this. Couse' this issue is 3 weeks old and nobody said anything about it.

@ghost
Copy link

ghost commented Nov 2, 2020

Any luck?

@Jwhiles
Copy link
Contributor

Jwhiles commented Nov 16, 2020

Hey @lexstefan if you're able to work on a PR for this feature that would be great. Otherwise, if it's a feature you'd like to see added could you submit your feature request through the support link on this page? Cheers!

@Jwhiles Jwhiles closed this as completed Nov 16, 2020
@OriginalEXE
Copy link
Contributor

Hey everyone,

Just to let you know that thew latest version of the Shopify app now fixes this issue, variant name (or sku if available) should now show up instead of the id. Hopefully this makes it more useable.

I have also added support for picking products and collections (and not just product variants), you can configure the behavior in the app config page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants