feat(dam-app-base): replace react-searchable-hoc with dndkit #7431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ecommerce-app-base-components canceled.
|
ethan-ozelius-contentful
force-pushed
the
eozelius/replace-react-searchable-hoc-with-dndkit
branch
2 times, most recently
from
34ee30a
to
27e6221
Compare
| @@ -121,164 +128,206 @@ const AdditionalDataDisplay = ({ additionalData }: AdditionalDataDisplayProps) = | |||
| ); | |||
| }; | |||
|
|
|||
| const DragHandle = SortableHandle<DragHandleProps>( | |||
There was a problem hiding this comment.
This component stayed the same, other than removing the SortableHandle<DragHandleProps> wrapper that was exposed by react-sortable-hoc.
ethan-ozelius-contentful
force-pushed
the
eozelius/replace-react-searchable-hoc-with-dndkit
branch
2 times, most recently
from
60c6cf7
to
b58aa46
Compare
|
|
||
| const SortableItem = SortableElement<SortableElementProps>((props: SortableElementProps) => { |
There was a problem hiding this comment.
the SortableItem component also stays much the same. Just swapping out react-sortable-hoc's SortableElement wrapper for dndkit's useSortable() hook. And passing the response to <Card>
|
|
||
| export class SortableComponent extends React.Component<Props> { |
There was a problem hiding this comment.
Merge SortableComponent and SortableList into one component.
jsdalton
previously approved these changes
Apr 29, 2024
ethan-ozelius-contentful
force-pushed
the
eozelius/replace-react-searchable-hoc-with-dndkit
branch
from
b58aa46
to
57baf88
Compare
whitelisab
approved these changes
Apr 30, 2024
ethan-ozelius-contentful
deleted the
eozelius/replace-react-searchable-hoc-with-dndkit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Migrate
react-sortable-hoctodndkit, sincereact-sortable-hocis no longer supported, and is not compatible with versions of react higher than v16.This will unblock us from upgrading to react v18.
Approach
Swap out
react-sortable-hocwrappers for newer styledndkithooks.Screenshots