Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support shouldPublish Option in setTagsForEntries #1230

Open
pellebjerkestrand opened this issue Jul 19, 2023 · 0 comments
Open

Support shouldPublish Option in setTagsForEntries #1230

pellebjerkestrand opened this issue Jul 19, 2023 · 0 comments

Comments

@pellebjerkestrand
Copy link

Expected Behavior

Setting the shouldPublish option when calling setTagsForEntries should result in the same behavior as when setting the shouldPublish options when calling transformEntries.

Actual Behavior

shouldPublish is unsupported.

If using TypeScript, we get this message, which makes sense.

Object literal may only specify known properties, and 'shouldPublish' does not exist in type 'ISetTagsForEntriesConfig'

If we run the migration anyway, the option is ignored.

Possible Solution

Support shouldPublish as an option when calling setTagsForEntries.

Or maybe it's better to be able to set tags and fields with the same migration function.

Steps to Reproduce

Set the shouldPublish option when calling setTagsForEntries.

Context

We sometimes only migrate tags.

Environment

  • Package Version: 4.14.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant