fix: allow asset links in entry types #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veu
force-pushed
the
fix-asset-link-types
branch
from
1e99304
to
2f911df
Compare
veu
commented
Feb 22, 2023
| } | ||
| const metadataValue = { tags: [] } | ||
| // @ts-ignore | ||
| import * as mocks from './mocks' |
There was a problem hiding this comment.
The error is that we’re only allowed to import from lib where we definitely don’t want the mocks. I’m doing a * import to make sure I’m not hiding other errors like mock data not being exported.
Cyberxon
approved these changes
Feb 23, 2023
|
🎉 This PR is included in version 10.0.0-beta-v10.16 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before this PR the entry types resolved all asset links to entries and entry links. Let’s fix that.
Description
EntryFields.EntryLinkandEntryFields.AssetLinkto distinguish between the different link typesNewEntrytypeFieldTypefrom generic entry types to indicate that the fields property can have different shapesEntryFields.Object