feat: add order query parameter #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Silhoue
reviewed
Mar 21, 2023
| type SupportedLinkTypes = EntryFields.AssetLink | EntryFields.EntryLink<any> | undefined | ||
|
|
||
| export type OrderFilterPaths<Fields extends FieldsType, Prefix extends string> = | ||
| | `${Prefix}.${keyof ConditionalPick<Fields, SupportedTypes> & string}` |
There was a problem hiding this comment.
Why do we need the & string here? Isn't keyof FieldsType always a string?
There was a problem hiding this comment.
In some cases it’s just string. Here we get string | number so we have to remove number to make TS happy.
Silhoue
reviewed
Mar 21, 2023
Silhoue
reviewed
Mar 21, 2023
Silhoue
approved these changes
Mar 21, 2023
|
🎉 This PR is included in version 10.0.0-beta-v10.30 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
orderparameter forgetAssets,getEntries, andgetTagsqueries.