Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import contentful from 'contentful' changed behaviour #42

Closed
grncdr opened this issue Aug 24, 2015 · 5 comments
Closed

import contentful from 'contentful' changed behaviour #42

grncdr opened this issue Aug 24, 2015 · 5 comments
Assignees

Comments

@grncdr
Copy link
Contributor

grncdr commented Aug 24, 2015

When we moved to ES6, users of this library who are also using Babel get subtly different behaviour when importing. Now when you import contentful from 'contentful' you don't get an object containing all exported functions, but rather the (non-existant) default export from this library. We need a backwards compatible export default statement.

@wmadden
Copy link

wmadden commented Aug 24, 2015

@grncdr related to this topic, users who're compiling Contentful from source will also be hit by the "bug" in axios that it imports and forcefully polyfills the global Promise implementation with the es6-promise polyfill.

This caused problems for us because es6-promise won't handle errors that aren't caught in a call to catch() at all - they just get eaten.

@rossthedevigner
Copy link

Just came upon this issue today... 1.1.5

@trodrigues
Copy link
Contributor

Keeping an eye on the next release of axios which will fix the issue.

@trodrigues
Copy link
Contributor

Created #44 to track that.

@trodrigues
Copy link
Contributor

Fixed on 2.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants