Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rich text types package #557

Merged
merged 1 commit into from Jan 13, 2021
Merged

Conversation

marcolink
Copy link
Member

Description

The locally defined types for rich text content are inaccurate.
Instead, we use a dedicated types package for rich-text- types.

@marcolink marcolink added this to the Typescript migration milestone Jan 13, 2021
@marcolink marcolink requested a review from a team January 13, 2021 08:35
@codecov
Copy link

codecov bot commented Jan 13, 2021

Codecov Report

Merging #557 (2275462) into experimental (e222883) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           experimental     #557   +/-   ##
=============================================
  Coverage         88.29%   88.29%           
=============================================
  Files                 8        8           
  Lines               188      188           
  Branches             42       37    -5     
=============================================
  Hits                166      166           
  Misses               22       22           
Flag Coverage Δ
integrationtests 77.12% <100.00%> (ø)
unittests 83.51% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/create-contentful-api.ts 96.92% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e222883...2275462. Read the comment docs.

The locally defined types for rich text content are inaccurate. Instead, we use a dedicated types package for richt-text- types.
Copy link
Contributor

@ruderngespra ruderngespra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marcolink marcolink merged commit f140366 into experimental Jan 13, 2021
@marcolink marcolink deleted the ts/use-rich-text-types branch January 13, 2021 11:17
@ghost
Copy link

ghost commented Mar 16, 2022

🎉 This PR is included in version 10.0.0-beta-v10.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants