Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(visual-editor): show hovered component outlines when hovering the layers tab [ALT-673] #584

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

primeinteger
Copy link
Contributor

Purpose

This change revises the hoverComponent event to render the hover component outlines in the canvas when you are hovering over components in the layers tab.

Ticket: https://contentful.atlassian.net/browse/ALT-673

In this demo video, I start by hovering over components in the canvas, and then hover over components in the layers tab to show the same outlines being rendered in the canvas for both cases. Hover outlines are removed when moving the mouse to the "blank" area of the canvas or other parts of the UI.

Screen.Recording.2024-04-25.at.2.46.36.PM.mov

@primeinteger primeinteger requested review from a team as code owners April 25, 2024 21:02
Copy link

vercel bot commented Apr 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
experience-builder-test-app ✅ Ready (Inspect) Visit Preview Apr 25, 2024 9:02pm

Copy link
Contributor

@ryunsong-contentful ryunsong-contentful left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. The only question I have is there's no way to get into a de-selected state in the Layers tab. I physically have to use the canvas for that. Probably a separate issue but could be a nice quick follow up or added in this PR where I can click in the white space of the layers tab and get into a clean de-selected mode. (This is probably a UI change rather than in EB)

@primeinteger
Copy link
Contributor Author

Overall looks good to me. The only question I have is there's no way to get into a de-selected state in the Layers tab. I physically have to use the canvas for that. Probably a separate issue but could be a nice quick follow up or added in this PR where I can click in the white space of the layers tab and get into a clean de-selected mode. (This is probably a UI change rather than in EB)

That's exactly what https://github.com/contentful/user_interface/pull/20912 does!

@chasepoirier
Copy link
Contributor

Looks great! Love seeing a net decrease in lines of code with this 🤌

@primeinteger primeinteger merged commit 34f0dee into development Apr 26, 2024
9 checks passed
@primeinteger primeinteger deleted the ALT-673/canvas-hover-states branch April 26, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants