Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type for HttpProgress struct #77

Open
Boddlnagg opened this issue May 20, 2019 · 0 comments
Open

Fix type for HttpProgress struct #77

Boddlnagg opened this issue May 20, 2019 · 0 comments

Comments

@Boddlnagg
Copy link
Collaborator

I just stumbled upon the fact that HttpProgress seems to be the only struct that contains reference types as members (Windows.Foundation.IReference<u64>).

Currently this is projected as *mut windows::foundation::IReference<u64>, but we probably don't want to have a raw pointer here. I think that ComPtr<windows::foundation::IReference<u64>> would be correct (i.e. when we get an instance of that struct, the members have their reference count incremented, and we have to Release() the interfaces when we drop the struct), but I'm not 100% sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant