Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add HTTP HEAD operation #76

Merged
merged 3 commits into from
Apr 19, 2022
Merged

feat: add HTTP HEAD operation #76

merged 3 commits into from
Apr 19, 2022

Conversation

megaflo
Copy link
Contributor

@megaflo megaflo commented Mar 4, 2022

This PR adds support for HEAD operations.

How Has This Been Verified?

A test has been added that generates code from a simple api.yaml that contains a HEAD operation on a path and compares it to the expected result.

Checklist:

  • The change works as expected.
  • New code can be debugged via logs.
  • I have added tests to cover my changes.
  • I have locally run the tests and all new and existing tests passed.
  • Requires updates to the documentation.
  • I have made the required changes to the documents.

@megaflo megaflo requested a review from a team as a code owner March 4, 2022 10:47
@megaflo megaflo requested review from LucasRoesler and removed request for a team March 4, 2022 10:47
LucasRoesler
LucasRoesler requested changes Mar 4, 2022
View reviewed changes
Copy link
Member

@LucasRoesler LucasRoesler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, you just need to run the formatting/linter and push again

@LucasRoesler LucasRoesler merged commit 4d4b429 into master Apr 19, 2022
@LucasRoesler LucasRoesler deleted the head_operation branch April 19, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucasRoesler LucasRoesler LucasRoesler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@megaflo @LucasRoesler