fix: ensure nestd allOfs are correctly resolved #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust the schema merge logic to include allOf resolution. This ensures that nested allOf's are correctly merged together. Adjust some of the model properties generation to handle some edge cases that were discovered for singleton allOfs. Resolves #94 Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
megaflo
reviewed
Apr 3, 2023
Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
LucasRoesler
commented
Apr 3, 2023
...erators/models/testdata/cases/allOf_enum_merging_and_validation/expected/model_connection.go
Show resolved
Hide resolved
|
Maybe for another PR, but I'm having issues with the dependency: |
|
I just tested it with my full schema and it works perfect!! Thanks!! |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
@LucasRoesler what else is needed to merge? |
|
Nothing is blocking it, i was just traveling for a few days. Merging now. |
LucasRoesler
pushed a commit
that referenced
this pull request
Apr 8, 2023
🤖 I have created a release \*beep\* \*boop\* --- ### [2.0.1](https://www.github.com/contiamo/openapi-generator-go/compare/v2.0.0...v2.0.1) (2023-04-08) ### Bug Fixes * ensure nestd allOfs are correctly resolved ([#95](https://www.github.com/contiamo/openapi-generator-go/issues/95)) ([d6605c6](https://www.github.com/contiamo/openapi-generator-go/commit/d6605c6a59c72979cd1c850e444610fcb4f5c8f2)) This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the schema merge logic to include allOf resolution. This ensures that nested allOf's are correctly merged together.
Adjust some of the model properties generation to handle some edge cases that were discovered for singleton allOfs.
Resolves #94