Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: API endpoint for points? #40

Closed
aluhrs13 opened this issue Apr 16, 2023 · 4 comments · Fixed by #69
Closed

[Feature]: API endpoint for points? #40

aluhrs13 opened this issue Apr 16, 2023 · 4 comments · Fixed by #69

Comments

@aluhrs13
Copy link

Maybe I’m misunderstanding the API, but it seems like it only works with groundingDINO right now.

Would it be possible to add a field to the API endpoint that takes in a series of points that are the equivalent of where you would click in the UI? Or maybe a mask of green and/or red that gets translated into include/exclude points?

@continue-revolution
Copy link
Owner

Yes, I have already discussed this with @jordan-barrett-jm . He is the main contributor of API and he has been helping me a lot while I’m working on other features. When he has time, he will improve API support.

@jordan-barrett-jm
Copy link
Contributor

I can work on this soon @continue-revolution. I wanted to be clear though that the intended field would accept an array of tuples?

@continue-revolution
Copy link
Owner

In my code, it is two N*2 arrays. Not sure whether tuple can work.

@aluhrs13
Copy link
Author

Awesome! From my perspective as the asker for this - I have two lists of X,Y coordinates. Translating that to some other structure to match the API shape probably shouldn’t be a problem.

@continue-revolution continue-revolution changed the title API endpoint for points? [Feature]: API endpoint for points? Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants