Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSI u mode confuses neovim #1373

Closed
classabbyamp opened this issue Dec 20, 2023 · 2 comments · Fixed by #1387
Closed

CSI u mode confuses neovim #1373

classabbyamp opened this issue Dec 20, 2023 · 2 comments · Fixed by #1387
Labels
bug Something isn't working VT: Backend Virtual Terminal Backend (libterminal API)
Milestone

Comments

@classabbyamp
Copy link

classabbyamp commented Dec 20, 2023

Contour Terminal version

0.4.0

Installer source

Github: source code cloned (Void package, technically)

Operating System

Void Linux

Architecture

x86-64

Other Software

neovim 0.9.4
vim-surround at this commit, I think: https://github.com/tpope/vim-surround/tree/baf89ad26488f6a7665d51b986f5c7ad2d22b30b

Steps to reproduce

  1. set keyboard layout to non-ANSI QWERTY (I'm using Canadian French, e.g. setxkbmap -layout ca)
  2. enter neovim
  3. enter insert mode and type 'a'
  4. leave insert mode, put the cursor over the a, and type cs'" to change the surrounding ' to "

Expected Behavior

buffer contains "a"

Actual Behavior

buffer contains <80><fc>^B"a<80><fc>^B"

Additional notes

See also:

I believe this is caused by CSI u mode not having the semantics neovim expects. Following the semantics foot uses in the above PR will probably fix this. On my layout, " is Shift + 2 (and ' is Shift + ,, so this can be reproduced with other combinations of characters like cs"')

@classabbyamp classabbyamp added the bug Something isn't working label Dec 20, 2023
@christianparpart christianparpart added this to the 0.4.1 milestone Dec 22, 2023
@whisperity whisperity added VT: Backend Virtual Terminal Backend (libterminal API) platform: linux topics that directly address Linux platform (any distro) labels Dec 23, 2023
@christianparpart christianparpart removed the platform: linux topics that directly address Linux platform (any distro) label Dec 25, 2023
@christianparpart
Copy link
Member

Merry christmas, @classabbyamp . I have fixed this now and it works for me (i could repro it using German keyboard layout as well). I would still like you to confirm that it also works for YOU. :)

You may need to rebuild from source. Please ping us, if you need some kind of assistance.

@classabbyamp
Copy link
Author

can confirm that it is fixed with that patch, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working VT: Backend Virtual Terminal Backend (libterminal API)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants