Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouse scrolling is not working on not-main profile. #1424

Closed
kierun opened this issue Jan 26, 2024 · 5 comments · Fixed by #1438
Closed

Mouse scrolling is not working on not-main profile. #1424

kierun opened this issue Jan 26, 2024 · 5 comments · Fixed by #1438
Labels
bug Something isn't working frontend Contour Terminal Emulator (GUI frontend)

Comments

@kierun
Copy link

kierun commented Jan 26, 2024

Contour Terminal version

0.4.1

Installer source

something else (please specify below)

Operating System

Fedora Linux 39

Architecture

x86-64

Other Software

N.A.

Steps to reproduce

  1. Add this below the main profile:
    large:
        terminal_size:
            columns: 120
  1. Run contour profile large
  2. In the new terminal, cat some long file.
  3. Use the mouse to scroll up.

Expected Behavior

I expect the same behaviour as per the main profile: the mouse scrolls up.

Actual Behavior

The mouse does nothing: the view does not change.

Additional notes

I am pretty sure I must have missed something, but I am really unsure what it is. So, either it is a bug or the documentation could be improved. Either way, I am happy to help.

@kierun kierun added the bug Something isn't working label Jan 26, 2024
@christianparpart
Copy link
Member

Hey @kierun. Many thanks for your interest and bug report. I'm sorry to see you having troubles with Contour. We'll be trying to investigate on this as soon as possible.

Sorry for the inconveniences.

@christianparpart christianparpart added the frontend Contour Terminal Emulator (GUI frontend) label Jan 28, 2024
@kierun
Copy link
Author

kierun commented Jan 29, 2024

@christianparpart Thank you. Anything you need, please ask. I am happy to help in any ways I can.

@christianparpart
Copy link
Member

I just reproduced it with your above configuration. The reason why mouse scrolling is not working is, because there's no history limit set, and that's defaulting to 0. Once you add a history limit, it'll all just work.

I know, that configuration loading/reloading is currently not perfect. We're aware of it, and first work in form of a pending PR is already ongoing.

Apart from that, I wonder what a sane default would be, probably not 0, as in: no history limit, maybe. Maybe a conservative limit of 1000 to (more useful) 10000 would be a good default.

@kierun
Copy link
Author

kierun commented Jan 30, 2024

I confirm that setting the history to a none-zero value works. That's perfect, thank you.

@Yaraslaut
Copy link
Member

I confirm that setting the history to a none-zero value works. That's perfect, thank you.

bug with default history limit is fixed, so you might just delete this part of profile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Contour Terminal Emulator (GUI frontend)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants