Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash: Cursor (63, 0) does not match clamp to screen (63, 56). #1444

Closed
herrhotzenplotz opened this issue Jan 31, 2024 · 5 comments · Fixed by #1450
Closed

Crash: Cursor (63, 0) does not match clamp to screen (63, 56). #1444

herrhotzenplotz opened this issue Jan 31, 2024 · 5 comments · Fixed by #1450
Labels
blocker release-blocking action item crash(-like) Bug that results in severe state corruption, lock-ups with recovery, or outright termination high priority High Priority Item

Comments

@herrhotzenplotz
Copy link
Contributor

Short overview

I am currently seeing repeated crashes of contour:

===============================================================================================================================================================================================================================================
Cursor (63, 0) does not match clamp to screen (63, 56).
===============================================================================================================================================================================================================================================
Rendered screen at the time of failure
main page size       : 239x64
history line count   : 1000 (max 1000)
cursor position      : (63, 0)
vertical margins     : 0..63
horizontal margins   : 0..238
main page lines: scrollback cur 1000 max 1000, main page lines 64, used lines 1064, zero index 412
===============================================================================================================================================================================================================================================
<snip>
Image pool:
global image stats: 0 instances, 0 raster, 0 fragments
=============================================================
Hashtale: ImagePool name-to-image mappings
-------------------------------------------------------------
hashslot collisions : 0 (0%)
stats               : 0 hits, 0 misses, 0 evictions, 0% hit rate
hash table capacity : 1024 (0% utilization)
entry count         : 0
entry capacity      : 100 (0% utilization)
-------------------------------------------------------------
===============================================================================================================================================================================================================================================
Abort trap (core dumped)
$

Again, this is FreeBSD 14.0-RELEASE-p4 amd64 with FreeBSD clang 16 and Qt 6. The entire thing is running in a pure Wayland environment.

Reproduce

The issue seems to be quickly reproducible by producing output to the terminal and moving the mouse at the same time.

I did this by running: while :; do ls -lapho; done and then moving the mouse. Contour then crashes within milliseconds.

Logs / Debugger trace

See log at https://gist.githubusercontent.com/herrhotzenplotz/4695175147c1b77c4b6f09aee38e98c5/raw/0a661996166c9dffb7322eee0478a25c5af27be2/log
If you wish that I re-run the same thing again with fancy debug options, please let me know. :-)

@christianparpart
Copy link
Member

Oh, this is a very rare occasion. Many thanks for the report. 🤔 ...

@herrhotzenplotz
Copy link
Contributor Author

Actually, it wasn't that rare. I was seeing exactly this crash at least 3 times within one hour of using kakoune in contour making it pretty much too unreliable to use.

@Yaraslaut
Copy link
Member

I also encounter crashes from time to time, but not that often, and was not able to find ways to reliably repro this, lets hope this is it :)

@herrhotzenplotz
Copy link
Contributor Author

I just got a crash from inside kakoune: https://gist.githubusercontent.com/herrhotzenplotz/4695175147c1b77c4b6f09aee38e98c5/raw/92a5c34b7eaf6909cf9646da77c3caa862276c87/log2

It indeed seems to be the same assertion tripping.

@Yaraslaut Yaraslaut added blocker release-blocking action item crash(-like) Bug that results in severe state corruption, lock-ups with recovery, or outright termination labels Feb 1, 2024
@Yaraslaut Yaraslaut added this to the 0.3.x milestone Feb 1, 2024
@christianparpart christianparpart added the high priority High Priority Item label Feb 2, 2024
@christianparpart christianparpart removed this from the 0.3.x milestone Feb 2, 2024
@christianparpart
Copy link
Member

@herrhotzenplotz I cannot reproduce it, but I am pretty sure I've found something that must have caused this. Would you please mind testing the fix (#1450)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker release-blocking action item crash(-like) Bug that results in severe state corruption, lock-ups with recovery, or outright termination high priority High Priority Item
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants