Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text run segmentation problems #395

Closed
christianparpart opened this issue Aug 16, 2021 · 0 comments · Fixed by #1401
Closed

text run segmentation problems #395

christianparpart opened this issue Aug 16, 2021 · 0 comments · Fixed by #1401
Labels
bug Something isn't working fonts font rasterization and text shaping API and platform implementations VT: rasterizer Rendering of the terminal into a pixmap using `terminal_renderer` library
Milestone

Comments

@christianparpart
Copy link
Member

christianparpart commented Aug 16, 2021

Example screenshot:

image

Reproduction snippet:

echo -e "\e[31mabc\e[32m...\e[m\nabc...\n"

Text run segmentation properties:

image

Notes

Text run egmenation should happen based

  • SGR attributes
  • word delimitation (whitespace)
  • script property
  • emoji presentation property

A single text sub run contains has each of these properties fixed for a sequence of codepoints.

So in theory for the above example "abc..." should be one single sub-run (because "Common" script will be merged into "Latin" script)

Also, I could not find another case that has similar issues to this. It seems to only affect this case (AFAICT) with some text followed by the "..."-ligature using "JetBrainsMono" (or Fira Code, others?).

Maybe first validate if that holds true for the above reproducible case by looking at the debug output for debug tags font.*

@christianparpart christianparpart added bug Something isn't working VT: rasterizer Rendering of the terminal into a pixmap using `terminal_renderer` library fonts font rasterization and text shaping API and platform implementations labels Aug 16, 2021
@christianparpart christianparpart added this to the 0.2.1 bugfix release milestone Aug 16, 2021
@christianparpart christianparpart modified the milestones: 0.3.0, 0.3.1 Apr 1, 2022
@christianparpart christianparpart modified the milestones: 0.3.2, 0.4.0, 2023-1 Dec 28, 2022
@christianparpart christianparpart added this to the 0.4.2 milestone Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fonts font rasterization and text shaping API and platform implementations VT: rasterizer Rendering of the terminal into a pixmap using `terminal_renderer` library
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant