Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid bundling GraphiQL #203

Closed
Jomik opened this issue Dec 2, 2021 · 3 comments
Closed

Avoid bundling GraphiQL #203

Jomik opened this issue Dec 2, 2021 · 3 comments

Comments

@Jomik
Copy link

Jomik commented Dec 2, 2021

Hey!
Would it be possible to avoid bundling GraphiQL directly, but simply have it as an (optional?) peer dependency?
I am currently having some issue using defer with the latest version of GraphQL Helix and GraphQL 16 (experimental). I suspect this is due to helix using an outdated version of GraphiQL?
Why does it have to be a direct dependency? Could renderGraphiQL not simply take an argument, or make use of a peer dependency?

@saihaj
Copy link
Contributor

saihaj commented Dec 2, 2021

Would it be possible to avoid bundling GraphiQL directly

yes once we have #140

I am currently having some issue using defer with the latest version of GraphQL Helix and GraphQL 16 (experimental).

Helix comes with support for defer and stream with whatever is the latest tag for v16 experimental. Is there a particular functionality that is broken for you?

@Jomik
Copy link
Author

Jomik commented Dec 3, 2021

It simply 'does not work'.
I have a query where I tagged a fragment with defer, and I see that it still waits for the full thing. processRequest also simply returns a RESPONSE.
I am unsure if I missed something.
I use GiraphQL to build my schema.

@Jomik
Copy link
Author

Jomik commented Dec 3, 2021

Aaaand, it seems to be due to me having useGraphQlJit in my envelop.
Removing that makes defer work.
https://www.envelop.dev/plugins/use-graphql-jit

@Jomik Jomik closed this as completed Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants