feat: don't wrap strings, either

yocontra · Nov 15, 2017 · 95edc69 · 95edc69
1 parent 0436fb5
commit 95edc69
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/index.js b/src/index.js
@@ -110,7 +110,6 @@ class MediaQuery extends React.Component {
     const hasMergeProps = Object.keys(props).length > 0
     const childrenCount = React.Children.count(this.props.children)
     const wrapChildren = this.props.component ||
-      typeof this.props.children === 'string' ||
       this.props.children === undefined
     if (wrapChildren) {
       return React.createElement(

diff --git a/test/index_test.js b/test/index_test.js
@@ -45,6 +45,15 @@ describe('MediaQuery', function () {
       const e = TestUtils.renderIntoDocument(mq)
       assert.isNotFalse(TestUtils.findAllInRenderedTree(e, function () {return true}))
     })
+    it('does not wrap text node', function () {
+      const mq = (
+        <MediaQuery query="all">
+          1231
+        </MediaQuery>
+      )
+      const e = TestUtils.renderIntoDocument(mq)
+      assert.throws(() => (TestUtils.findRenderedDOMComponentWithTag(e, 'div')), /Did not find exactly one match/)
+    })
     it('renders the wrapper', function () {
       const mq = (
         <MediaQuery query="all" component="section">