fix usage of idiomatic react props

[ChrisSki]

I think line 49 this.query = toQuery(omit(props, excludedQueryKeys)); was excluding the idiomatic props from being used in toQuery. I was getting Invalid or missing MediaQuery! when not using the query string.

[yocontra]

Can you provide an example of where it was breaking?

[ChrisSki]

@contra how exactly should I do this? would you like to see how I'm using is in my code?

[yocontra]

@ChrisSki The code that was not working. I don't think I'm understanding what the problem was

[ChrisSki]

I'll do my best to explain. The following works:

<Mq query="(min-width: 1024px)">
            <div className="actions">
              <div className="action"><span className="actions-create" onClick={this.createNewBoard}>Create New Board</span></div>
              {showUpgrade}
            </div>
          </Mq>

The following does not work:

<Mq minWidth={1100}>
            <div className="actions">
              <div className="action"><span className="actions-create" onClick={this.createNewBoard}>Create New Board</span></div>
              {showUpgrade}
            </div>
          </Mq>

I tried debugging the code and found that when I removed the omit function from this.query = toQuery(omit(props, excludedQueryKeys)); the correct properties, in this case minWidth, work as expected. The only thing I could reason here, was that omit was excluding the properties from mediaQuery.all. I wasn't sure why they would or should be excluded so that was why I tested that case. There is another omit function when declaring props in the render function of index.js and I'm not sure why these are being omitted. However, since this scenario worked for me I didn't remove it.

I attempted other properties that are listed in mediaQuery.js as well, but that did not change the result.

[yocontra]

I think the real issue is https://github.com/ChrisSki/react-responsive/blob/idiomatic/src/index.js#L18 needs to be changed to Object.keys(defaultTypes)

[ChrisSki]

Looking at it again, I think you're correct. Would you like to fix it or would you like me to submit another PR?

[yocontra]

Another PR or updating this one would be fine

[ChrisSki]

@contra what was actually happening was the types assignment destroyed the initial defaultTypes object before it made it to the updateQuery function. When I moved excludedQueryKeys above types things worked fine. Since types is no longer being used, I removed it.