Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
With this pull request I am fixing the memory leak described in issue 104.
Firstly I had to change the package
matchmedia
to expose thedispose
method so we can remove all listeners attached to the DOM. The author ofmatchmedia
accepted my pull request but he never published the new version ofmatchmedia
to the npm repository. So I published the corrected package under a different namematchmediaquery
.In this pull request:
matchmediaquery
rather thanmatchmedia
.dispose
method to ensure that all listeners are removed.cross-env
so that this package can be compiled on windows.I hope it all makes sense and that this pull request can be consumed. I've tested it in our project and it works well. If you have any question or comments, feel free to ask.
Regards