Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Cannot read property 'removeListener' of undefined #109

Merged
merged 2 commits into from Jul 14, 2017
Merged

fix Cannot read property 'removeListener' of undefined #109

merged 2 commits into from Jul 14, 2017

Conversation

modosc
Copy link
Contributor

@modosc modosc commented Jul 14, 2017

right now >1.3.0 is totally broken for me, i get this error:

     TypeError: Cannot read property 'removeListener' of undefined
      at Mql.dispose (node_modules/react-responsive/dist/react-responsive.js:1051:9)
      at MediaQuery.updateQuery (node_modules/react-responsive/dist/react-responsive.js:176:20)
      at MediaQuery.componentWillReceiveProps (node_modules/react-responsive/dist/react-responsive.js:151:13)
      at node_modules/react-dom/lib/ReactCompositeComponent.js:610:23

this fix also depends on ncochard/matchmediaquery#1 - until that's merged and used here this test will continue to fail (i tested this locally though and combined together both seem to fix the problem)

@modosc
Copy link
Contributor Author

modosc commented Jul 14, 2017

ok - this should be good to go now.

@yocontra yocontra merged commit 694f18e into yocontra:master Jul 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants