switch to matchmedia module for client/server abstraction #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| var defaultTypes = { | ||
| component: React.PropTypes.func, | ||
| query: React.PropTypes.string | ||
| query: React.PropTypes.string, | ||
| values: React.PropTypes.object |
There was a problem hiding this comment.
can you define the shape of this object with React.PropTypes.shape? also need docs on this new prop
|
lgtm just need more info on the new prop then 👍 |
|
I think I got everything. Diff is large because I rebuilt the samples to add the static sample. |
|
I removed the rebuilding of dists |
| ```js | ||
| var mq = require('react-responsive'); | ||
| ```jsx | ||
| var Mq = require('react-responsive'); |
There was a problem hiding this comment.
I dig MediaQuery, will update
|
Updated |
yocontra
pushed a commit
that referenced
this pull request
Feb 27, 2015
switch to matchmedia module for client/server abstraction
|
Thanks! Owe you a 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to keep this PR much smaller than anticipated due to the
matchmediamodules abstraction for client/server. It just takes an optional 2nd parameter,values, that it uses ifwindow.matchMediacan't be accessed.