Use hyphenate-style-name module instead of React internal
#16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
yocontra
pushed a commit
that referenced
this pull request
Aug 3, 2015
Use `hyphenate-style-name` module instead of React internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the latest react betas, Facebook has moved
hyphenateStyleNameto thefbjspackage and is explicitly telling people not to depend on these modules if you're not Facebook. I'm slightly unsure about the best way to go, but for now I've made a super-simple module that does the same as the Facebook one.This PR adds this module as a dependency and makes the component work on the latest React betas.
I also took the liberty of changing the proptypes require to
require('react').PropTypesas this seems less likely to break in the future, should they decide to rearrange the internals.