Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for React 0.14.0-beta1 #17

Merged
merged 2 commits into from
Aug 7, 2015

Conversation

frederickfogerty
Copy link
Contributor

No description provided.

@@ -29,7 +29,7 @@
"object-assign": "^2.0.0"
},
"peerDependencies": {
"react": ">=0.12.0"
"react": ">=0.12.0 || >= 0.14.0-beta1"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=0.12.0 should work just fine because 0.14.0-beta1 is >= 0.12.0

@yocontra
Copy link
Owner

yocontra commented Aug 7, 2015

Is this needed? see my comment

@frederickfogerty
Copy link
Contributor Author

No, it won't, >= does not match alpha versions.
@contra try for yourself at http://semver.npmjs.com/

@yocontra
Copy link
Owner

yocontra commented Aug 7, 2015

ugh, just switch it to * im sick of dealing with react version ranges - such a clusterfk

@frederickfogerty
Copy link
Contributor Author

If you want to switch to *, maybe you should remove the peer dependency altogether?

yocontra pushed a commit that referenced this pull request Aug 7, 2015
Add support for React 0.14.0-beta1
@yocontra yocontra merged commit 7eeaad5 into yocontra:master Aug 7, 2015
@frederickfogerty frederickfogerty deleted the patch-1 branch August 7, 2015 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants