support react 0.14 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is excluding 0.12 |
|
Didn't think about it. Are people still using that? :) Anyway I've added it. |
|
@0x80 Are you 100% sure that 0.14 doesn't fall within *? You may have been on a pre release |
|
No not 100% sure. When I was trying to fix the package.json npm kept giving me errors until I removed my node_modules and installed again. I'm not sure what got messed up there. But I've never seen a package depend on just * before. At first I had added react 0.14 to my package.json and tried a clean install with your 0.0.8. Your package failed as the only one in my dependencies, so I'm pretty sure it wasn't compatible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.