[Feature] Add option to require full name when signing CLA

[Holzhaus]

I'm not a lawyer, but our team was discussing if just recording the GitHub user name is enough. People might delete their accounts or their PR and we're unsure this could cause problems.

How about adding an options to require the actual name when signing, e. g.:

I, <your full name here>, have read the CLA document and I hereby sign the CLA.

It could then parse the name and add it to the JSON file. If the name is not present, doesn't consist of at least two words or contains invalid characters (e. g. *<>^~¿;÷|` etc.), the bot either ignores the message or posts an error message.

[ibakshay]

Hi @Holzhaus, thank you very much for reaching out to us.
Adding full name in the signature comment and storing it in the JSON file will be a good idea. I will add this feature to our backlog and please feel to create a pull request if you are interested in contributing to this project :).

One thing to note is that this bot already stores the contributor's GitHub account id which is immutable and so won't be altered even if the contributor changes his/her GitHub name.

This CLA bot stores the below information when the contributor signs the CLA

  "signedContributors": [
    {
      "name": "ibakshay",
      "id": 33329946,
      "comment_id": 712807508,
      "created_at": "2020-10-20T12:16:24Z",
      "repoId": 282192792,
      "pullRequestNo": 155
    }

[Holzhaus]

I'm not a lawyer, but there were concerns that a GitHub username might turn out to be insufficient in case of lawsuit. Do the lawyers at SAP think the username suffices? If so, this might be unnecessary.

[Holzhaus]

As a first step, it would be nice if signature contained the full name from the github profile, i.e. read the "name" value from https://api.github.com/user/USER_ID.

[schmoelder]

Hi, we would also appreciate this feature, as adding the option to specify an affiliation. Anything we can do to accelerate the development? Is there already a PR?