Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Unrelated user is tagged with @ in comment #91

Open
ivan opened this issue Jun 2, 2021 · 3 comments
Open

[BUG] Unrelated user is tagged with @ in comment #91

ivan opened this issue Jun 2, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@ivan
Copy link

ivan commented Jun 2, 2021

Describe the bug

On a project I do not control, in exadel-inc/CompreFace#543 (comment), the action seems to have inserted "@ivan" in the comment, causing GitHub to send an email to an unrelated ivan (me).

To Reproduce

I don't know, but "Ivan Kurnosau seems not to be a GitHub user" is probably related.

Expected behavior

Please don't @ unrelated GitHub users, it leads to undesired email from unrelated projects.

Screenshots

Screenshot 2021-06-02 073337

@ivan ivan added the bug Something isn't working label Jun 2, 2021
@github-actions github-actions bot added this to To do in project-board Jun 2, 2021
@pospielov
Copy link

Hi there, I'm a CompreFace repository contributor and looks like I know how to reproduce it.
So real Ivan Kurnosau has such config for git on a local machine:
user.email: ...@exadel.com
user.name: Ivan Kurnosau
But his GitHub Account has another email: ...@gmail.com
So, cla-assistant didn't find such a user and just used a local user.name to tag a user
But because user.name has space, it tagged @ivan
We will try to fix it from our side - just add the correct email to the GitHub account.
But this is definitely a bug, you shouldn't try to tag unknown users.

@ibakshay
Copy link
Member

ibakshay commented Jun 6, 2021

Hi @ivan, I am really sorry that this GitHub action has sent you a unrelated email. I will fix this bug soon.
@pospielov Thank you for the explanation :). You are absolutely right 😄.

@silviogutierrez
Copy link
Contributor

@pospielov : I believe this is still occurring, see here: silviogutierrez/reactivated#222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

4 participants