New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for nette/forms 3.1.14 #86
Comments
@dakorpar Please, unlock for all 3.1.x, it does not make any sense to update every two weeks. |
@f3l1x that will lead to MANY sites crashed after composer update. Nette/forms has BC every now and then and this library is also using internal functions that can change at any time. I did that mistake in beggining, won't do it again. I'll update in next few days. |
OK. |
Hmm, this is a bit tricky now... We already have Date and Datetime control in. Now if I switch to nette one it's breaking change and if I introduce a new different function for nette native controls interface won't be almost the same with nette forms anymore... I'll have to investigate more... |
Hi, any idea how to solve this problem? |
@dakorpar I´d say using the Nette ones is the right way, Dfferent way can just add more problems. Declare new version with breaking change. If Nette/Forms can do BCs and it does not matter that sites crash after composer update, there is no point going around with component that expands on NetteForms. And no one should be running composer update on production... |
I'm a bit buisy, if someone prepares a PR I'll take a look and modify if needed in day or two then, but to buisy to actually focus on that ATM. |
So you are going to rename those methods that are in conflict with the ones in nette/forms? |
@H0w4rd I don't have much room there... I have to stay compatible with nette forms, which means compatibility with nette/forms 3.1.14 will include BCs... |
compatibility with 3.1.15 done and released. 3.2.0 is also ready and will be released probably tomorrow. |
Can you please add support for current release of nette/forms (3.1.15)?
Thank you
The text was updated successfully, but these errors were encountered: