Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for nette/forms 3.1.14 #86

Closed
matoni555 opened this issue Feb 1, 2024 · 10 comments
Closed

Support for nette/forms 3.1.14 #86

matoni555 opened this issue Feb 1, 2024 · 10 comments

Comments

@matoni555
Copy link

Can you please add support for current release of nette/forms (3.1.15)?

Thank you

@matoni555 matoni555 changed the title Support for nette/form >=3.1.14 Support for nette/forms >=3.1.14 Feb 1, 2024
@f3l1x
Copy link
Member

f3l1x commented Feb 1, 2024

@dakorpar Please, unlock for all 3.1.x, it does not make any sense to update every two weeks.

@dakorpar
Copy link
Member

dakorpar commented Feb 1, 2024

@f3l1x that will lead to MANY sites crashed after composer update. Nette/forms has BC every now and then and this library is also using internal functions that can change at any time. I did that mistake in beggining, won't do it again.
Plus v3.1.14 adds new controls which I actually need to support here.
image

I'll update in next few days.

@dakorpar dakorpar closed this as completed Feb 1, 2024
@dakorpar dakorpar reopened this Feb 1, 2024
@f3l1x
Copy link
Member

f3l1x commented Feb 1, 2024

OK.

@dakorpar
Copy link
Member

dakorpar commented Feb 2, 2024

Hmm, this is a bit tricky now... We already have Date and Datetime control in. Now if I switch to nette one it's breaking change and if I introduce a new different function for nette native controls interface won't be almost the same with nette forms anymore... I'll have to investigate more...
@matoni555 feel free to send PR, this will probably be on hold for few more days if it's waiting for me. just changing composer.json IS NOT an option.

@H0w4rd
Copy link

H0w4rd commented Mar 4, 2024

Hi, any idea how to solve this problem?

@darkWolf-PR
Copy link

@dakorpar I´d say using the Nette ones is the right way, Dfferent way can just add more problems. Declare new version with breaking change. If Nette/Forms can do BCs and it does not matter that sites crash after composer update, there is no point going around with component that expands on NetteForms. And no one should be running composer update on production...

@dakorpar
Copy link
Member

dakorpar commented Mar 5, 2024

I'm a bit buisy, if someone prepares a PR I'll take a look and modify if needed in day or two then, but to buisy to actually focus on that ATM.

@H0w4rd
Copy link

H0w4rd commented Mar 5, 2024

So you are going to rename those methods that are in conflict with the ones in nette/forms?

@dakorpar
Copy link
Member

dakorpar commented Mar 12, 2024

@H0w4rd I don't have much room there... I have to stay compatible with nette forms, which means compatibility with nette/forms 3.1.14 will include BCs...
I've added new date/datetime/time/color controls now and had to rename current addDate and addDateTime to addBootstrapDate and addBootstrapDateTime... That's only thing I can do since my container basically "inherits" nette container and all calls need to be compatible... I'll do some testing tomorrow...
you can all also try it out with including:
"contributte/forms-bootstrap": "v0.7",

@dakorpar dakorpar changed the title Support for nette/forms >=3.1.14 Support for nette/forms 3.1.14 Mar 13, 2024
@dakorpar
Copy link
Member

compatibility with 3.1.15 done and released. 3.2.0 is also ready and will be released probably tomorrow.
closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

5 participants