-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Gopay\Api to other repo #34
Comments
I personally like it - I started this package without API in it, as the API and this library aren't same thing. Of course ideal situation would be if Gopay maintained their API by themselves :). |
I like it, too, I believe it's a good idea. When doing it, I think it would be fine to remove some inconsistencies in GopaySoap (half of functions is static, half isn't - in official api, all are static) |
It's a question. Keep it static or transform to something useful. I vote for keep it static. What do you think? |
👍 for keep it static (as @haltuf said: "in official api, all are static"). |
@f3l1x I've created base of the new repository: https://github.com/Markette/GopayApi It's an official GoPay PHP API from http://help.gopay.com/cs/tema/integrace-2/integrace-platebni-puvodni-brany/php-api-verze-2-5 But namespaced & with typos (oh, it's ugly code). We should also add some description and tag v1.0 or v2.5? (it's GoPay API 2.5) Can we then remove |
I would keep it static. The less changes are made to the official API, the easier it will be to maintain in next versions... Regarding the v3.0 in this repo, maybe we should wait a little bit, as this very change doesn't actually bring anything new for the user. I could imagine, that markette/gopay with functions from #35 could be a candidate for v3.0 (didn't think about it much yet, but I suspect there will be need for some changes that might ALSO introduce another BC break - maybe, maybe not - so why not to do it at once?) |
I prefer tag same as API version. We could create a milestone 3.0. There could be more changes, for example new dependency gopay-api, PHP 5.5 syntax, new features, more examples. |
@f3l1x Why PHP 5.5 syntax in milestone 3.0? 😮 Did you mean 5.4 due to short array syntax etc. or you really need 5.5 features? Personally I like 5.6, but still prefer 5.4 because of many of our clients have it on theirs hosting. |
@hranicka @haltuf Sure, PHP 5.4, my mistake. We've an API repo. https://github.com/Markette/GopayApi |
Merged #40 . |
I suggest to split Gopay\Api to other repo - Markette/GopayApi.
cons:
What do you think? @hrach @vojtech-dobes @hranicka @haltuf
The text was updated successfully, but these errors were encountered: