Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate js from html code #18

Closed
dbads opened this issue Oct 9, 2018 · 15 comments · Fixed by #69
Closed

separate js from html code #18

dbads opened this issue Oct 9, 2018 · 15 comments · Fixed by #69

Comments

@dbads
Copy link
Member

dbads commented Oct 9, 2018

You have to simply make a new js file and put the js code on any one html page to this new js file and then include that js file in html file. e.g Projects/templates/Projects/home.html has some js at bottom. put it in a different js file and include it in bottom again.

You have to do this just for any one html page.
Mention the name of html page while making prs?

@dbads
Copy link
Member Author

dbads commented Oct 9, 2018

name js files accordingly.

@XtheWiz
Copy link
Contributor

XtheWiz commented Oct 9, 2018

Can I take this issue ? @dbads

@dbads
Copy link
Member Author

dbads commented Oct 9, 2018

@XtheWiz okay you have been assigned this issue. after creating pr on GitHub also create a request on https://contrihubs.herokuapp.com for achieving points. 😄

@zilehuda
Copy link

zilehuda commented Oct 9, 2018

taking this one (Y)

@dbads
Copy link
Member Author

dbads commented Oct 9, 2018

@XtheWiz before starting mention the page name too and @zilehuda you can not work on same page as @XtheWiz

@dbads
Copy link
Member Author

dbads commented Oct 9, 2018

@zilehuda choose a different page from @XtheWiz 😄

@zilehuda
Copy link

zilehuda commented Oct 9, 2018

okay @dbads

@zilehuda
Copy link

zilehuda commented Oct 9, 2018

@dbads I am working on project module

@dbads
Copy link
Member Author

dbads commented Oct 9, 2018 via email

@XtheWiz
Copy link
Contributor

XtheWiz commented Oct 9, 2018

@dbads May I work on profile page :)

@dbads
Copy link
Member Author

dbads commented Oct 9, 2018

@XtheWiz yeah sure 👍

@dbads
Copy link
Member Author

dbads commented Oct 9, 2018

Now @zilehuda you should choose a page except profile page 😄

@dbads dbads added the good first issue Good for newcomers label Oct 9, 2018
@zilehuda
Copy link

zilehuda commented Oct 9, 2018

@dbads project module :)

@debodirno
Copy link

@dbads will work on home.html

@dbads
Copy link
Member Author

dbads commented Oct 9, 2018

@debodirno @zilehuda of course you can work if it's not already done by someone else 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants