Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of com.sun.javafx.scene.control.behavior.* classes #1399

Open
abhinayagarwal opened this issue Sep 29, 2021 · 1 comment
Open
Assignees

Comments

@abhinayagarwal
Copy link
Member

With #1395, we removed the use of Behavior classes from RangeSlider and SnapshotView, there is just one control which has a dependency on the com.sun.javafx.scene.control.behavior.* class i.e. GridViewBehavior.

It is complex to fix GridViewBehavior as it extends TableViewBehavior instead of BehaviorBase.

@Maxoudela can you have a quick look to see if we can do something about this class?

@Maxoudela
Copy link
Collaborator

Well.. There is quite a lot of code inside TableViewBehavior and TableViewBehaviorBase.
If we want to get rid of the dependencies, it means I have to get rid of the GridViewBehavior.
This also means I have to extends from TableViewSkin instead of TableViewSkinBase in the GridViewSkin (in order to have a TableViewBehavior constructed).

I can have access to some methods in the TableViewSkin, but some are missing. For example discontinuousSelectNextColumn() that is in the Behavior and that I need to override if I want the selection to work properly with the span.

If you have some ideas, let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants