Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.4.1 --from-stdin regression #142

Closed
yurrriq opened this issue Aug 24, 2023 · 5 comments
Closed

v0.4.1 --from-stdin regression #142

yurrriq opened this issue Aug 24, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@yurrriq
Copy link

yurrriq commented Aug 24, 2023

Describe the bug

v0.4.1 no longer exists with a nonzero status code when given an invalid commit message via --from-stdin

To Reproduce
Steps to reproduce the behavior:

$ echo 'bad commit message' | convco check --from-stdin
FAIL  -  first line doesn't match `<type>[optional scope]: <description>`  bad commit message
$ echo $?
0

Expected behavior

$ echo 'bad commit message' | convco check --from-stdin
FAIL  -  first line doesn't match `<type>[optional scope]: <description>`  bad commit message
$ echo $?
1

System (please complete the following information):

  • OS: [e.g. ubuntu] Ubuntu
  • Version: [e.g. 19.10] 22.04 LTS

Additional context

Works as expected with convco v0.4.0. At a glance, I suspect #137

@yurrriq yurrriq added the bug Something isn't working label Aug 24, 2023
@hdevalke
Copy link
Collaborator

Thank you for reporting, but I think this is fixed by #141. But it is not released yet.

@yurrriq
Copy link
Author

yurrriq commented Aug 25, 2023

Great, thanks! Any timeline on the next release? It's currently broken in NixOS/nixpkgs@master and I'd love to bump there.

@hdevalke
Copy link
Collaborator

I'll do my best to find time this weekend.

@hdevalke
Copy link
Collaborator

Done.

@hdevalke
Copy link
Collaborator

#143 created in order to improve releasing a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants