Skip to content
This repository has been archived by the owner on Feb 5, 2018. It is now read-only.

Needs to be called conventional-changelog-eslint? #1

Closed
gajus opened this issue May 17, 2016 · 2 comments
Closed

Needs to be called conventional-changelog-eslint? #1

gajus opened this issue May 17, 2016 · 2 comments

Comments

@gajus
Copy link

gajus commented May 17, 2016

I am trying to use conventional-changelog-eslint with https://github.com/marionebl/conventional-changelog-lint.

I have tried adding:

{
    "preset": "eslint"
}

to .convetional-changelog-lintrc.

I have tried executing program using:

./node_modules/.bin/conventional-changelog-lint
./node_modules/.bin/conventional-changelog-lint --preset eslint
./node_modules/.bin/conventional-changelog-lint --preset="eslint"

etc.

Regardless of what I do, conventional-changelog-eslint-lint uses the angular preset.

@gajus
Copy link
Author

gajus commented May 17, 2016

Upon further inspection, it looks like convention-changelog-eslint preset itself is not representative of the ESLint commit guidelines, e.g.

$ echo 'Breaking: Remove zeroFill in favor of _.padStart (refs #1)' | ./node_modules/.bin/conventional-changelog-lint -p eslint
parserOptions { preset: [Function: presetOpts],
  configuration:
   { extends: [ 'angular' ],
     rules:
      { 'type-enum': [Object],
        'type-case': [Object],
        'type-empty': [Object],
        'scope-case': [Object],
        'subject-empty': [Object],
        'subject-full-stop': [Object],
        'body-leading-blank': [Object],
        'header-max-length': [Object],
        lang: [Object] },
     wildcards: { merge: [Object], release: [Object], revert: [Object] },
     preset: 'eslint',
     _: [],
     p: 'eslint',
     configs: [ 'c:\\UBS\\Dev\\repositories\\krypton\\kwak-utilities\\.conventional-changelog-lintrc' ],
     config: 'c:\\UBS\\Dev\\repositories\\krypton\\kwak-utilities\\.conventional-changelog-lintrc' } } undefined
⧗   input: Breaking: Remove zeroFill in favor of _.padStart (refs #1)
✖   type must be one of ["feat", "fix", "docs", "style", "refactor", "test", "chore", "revert"] [type-enum]
✖   type must be lowerCase [type-case]
✖   found 2 problems, 0 warnings

@hutson
Copy link

hutson commented Feb 5, 2018

We're closing this issue out as this repository has been merged into our conventional-changelog mono-repository.

If you would like to see this change incorporated into conventional-changelog please consider re-opening the issue against the conventional-changelog mono-repository.

@hutson hutson closed this as completed Feb 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants