Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: define skip-unstable in opts so they are passed down to gitSemverTags #1066

Merged
merged 2 commits into from
Aug 13, 2023

Conversation

bleuarg
Copy link
Contributor

@bleuarg bleuarg commented Jul 17, 2023

Option definition for skip-unstable are missing in cli.js both for git-semver-tags and conventional-recommended-bump. So when running from command line the --skip-unstable opt is not passed to the actual gitSemverTags method.

I could not manage to validate the issue with conventional-recommended-bump but since it is defined in the options object, I've added it to the meow definition there too for consistency.

Likely addresses #754 and #675.

Validation

Example when running in this very repo:

Before
$ node packages/git-semver-tags/cli.js
v1.1.0
v1.0.2
v1.0.1
v1.0.0
v0.5.3
v0.5.2
v0.5.1
v0.5.0
v0.4.3
v0.4.2
v0.4.1
v0.4.0
v0.3.2
v0.3.1
v0.3.0
v0.2.1
v0.2.0
v0.1.3
v0.1.2
v0.1.1
v0.1.0
v0.1.0-beta.3
v0.1.0-beta.2
v0.1.0-beta.1
v0.1.0-alpha.3
v0.1.0-alpha.2
v0.1.0-alpha.1
v0.0.17
v0.0.16
v0.0.15
v0.0.14
v0.0.13
v0.0.11
v0.0.10
v0.0.9
v0.0.8
v0.0.7
v0.0.6
v0.0.4
After
$ node packages/git-semver-tags/cli.js
v1.1.0
v1.0.2
v1.0.1
v1.0.0
v0.5.3
v0.5.2
v0.5.1
v0.5.0
v0.4.3
v0.4.2
v0.4.1
v0.4.0
v0.3.2
v0.3.1
v0.3.0
v0.2.1
v0.2.0
v0.1.3
v0.1.2
v0.1.1
v0.1.0
v0.0.17
v0.0.16
v0.0.15
v0.0.14
v0.0.13
v0.0.11
v0.0.10
v0.0.9
v0.0.8
v0.0.7
v0.0.6
v0.0.4

@bleuarg bleuarg changed the title fix: define skip-unstable opts so they are passed down. fix: define skip-unstable in opts so they are passed down to gitSemverTags Jul 17, 2023
@dangreen dangreen self-requested a review July 17, 2023 17:13
Copy link
Member

@dangreen dangreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Thank you for the PR. Please rebase to current master.

@bleuarg
Copy link
Contributor Author

bleuarg commented Aug 8, 2023

@dangreen Hi, thanks for the feedback, rebased and pushed 👍.

@bleuarg bleuarg requested a review from dangreen August 8, 2023 13:40
@coveralls
Copy link

Coverage Status

coverage: 89.5%. remained the same when pulling b66f80b on bleuarg:fix/skip-unstable into 5e37788 on conventional-changelog:master.

@dangreen dangreen merged commit 0ffec3f into conventional-changelog:master Aug 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants