fix(conventional-changelog-conventionalcommits): optional config #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangreen
requested changes
Sep 5, 2023
| @@ -27,7 +27,7 @@ function createConventionalRecommendedBumpOpts (config, parserOpts) { | |||
| } | |||
| }) | |||
|
|
|||
| if (config.preMajor && level < 2) { | |||
| if (config?.preMajor && level < 2) { | |||
Comment on lines
80
to
81
| preset: { | ||
| name: 'conventionalcommits' | ||
| } | ||
| preset: 'conventionalcommits' | ||
| }, {}) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
lvjiaxuan
commented
Sep 5, 2023
Comment on lines
+74
to
+82
| it('should allow the string `conventionalcommits` as the preset option', async () => { | ||
| preparing(2) | ||
|
|
||
| await expect(() => conventionalRecommendedBump({ | ||
| cwd: testTools.cwd, | ||
| preset: 'conventionalcommits' | ||
| }, {})).not.toThrowError() | ||
| }) | ||
|
|
There was a problem hiding this comment.
Finally, I decided to add a test case. 😁
dangreen
approved these changes
Sep 5, 2023
This was referenced Sep 7, 2023
birtles
added a commit
to birchill/jpdict-idb
that referenced
this pull request
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It throws error, when the preset option is set to the string
conventionalcommits.