-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
latest release breaks changelog commit (note, this issue seems to potentially be related to dotgitignore) #231
Comments
|
From the output given in the OP, it looks like you're skipping the "bump" step (because the first line is "outputting changes to CHANGELOG.md" instead of "bumping version in package.json"), which happens if you use a CLI command like {
"standard-version": {
"skip": {
"bump": true
}
}
} Since the OP doesn't pass any flags to standard-version, I presume the latter. In my local testing, I also see this problem when skipping the "bump" step, but I see it when using version 4.2.0 as well. We have this test for skipping "bump" and "changelog" together, which looks like it should fail (via rejected promise) if the test has this problem (and I don't think the test fails), but I run into the failed "git commit CHANGELOG.md" command no matter what else I pass when skipping the "bump" step, so I'm not sure what's going on. That's all I've found so far. Hopefully this gets us one step closer to the root problem (and solution). In the meantime, @cludden can you please confirm that your package.json is configuring standard-version to skip the "bump" step? |
@nexdrew I'm using standard-version as a global npm install, and running as $ standard-version --release-as major The package.json from the project that I pasted the output above from does not have a |
@cludden interesting, perhaps there's a bug related specifically to global behavior; we'll need to dig into this. |
@cludden I believe I see the issue; do you have |
@bcoe I found a conflict with the |
@bcoe sorry for the late response. |
i ran into this with just |
Same problem for me. |
Having same issue with 4.3.0, upgraded to 4.4.0 and still have same issue with:
Error is outputted twice. |
I just got this issue on Using global standard-version install (via We would normally remove the tag prefix via This is only on a specific project as well - same install works fine on a different project. The project that fails is actually a dotnet project so the project.json is very simple - it has |
@simonfox any chance you could provide a link to a GitHub repo that minimally reproduces this issue? or even better a failing test case. Happy to try to help dig into this, but have been unable to reproduce this issue on any of my own projects. |
OK odd - just copied source of problematic project to a new folder and did So I dumped the problematic project and re-cloned and all working fine in there as well. Something in cc @bcoe |
@bcoe actually apologies it's definitely acting wierd....this seems to break - https://github.com/simonfox/sv-repro |
@simonfox fascinating, did you potentially have any git hooks configured is a thought? https://medium.com/the-andela-way/git-hooks-beautifully-automate-tasks-stages-bfb29f42fea1 can we close this potentially? |
@bcoe no hooks configured...does my repro not fail for you? I've just used repro (linked above ☝️ ) to confirm there is definitely oddness - |
@bcoe ok sorry this seems to be a different issue related to the change to respect Problematic lines are comment lines I've traced the issue back the Hope that helps! |
@simonfox this is a big help, would you mind submitting a patch with the latest version of |
@bcoe sure can - need latest on |
@simonfox tried to release |
@simonfox I've gone ahead and published the newer |
@bcoe thanks confirming latest release fixes the issue that I was hitting. |
@bcoe Seems this issue still not resolved in 5.0.2, which contains latest |
@huchenme mind opening a new issue, ideally with a repo that reproduces your issue; hopefully we can figure out the remaining causes. |
error:
rolling back to 4.2.0 fixes issue
The text was updated successfully, but these errors were encountered: