Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensures provided packageFiles arguments are merged with bumpFiles when no bumpFiles argument is specified (default). #534

Merged
merged 1 commit into from
Oct 19, 2021

Conversation

jbottigliero
Copy link
Member

closes #533

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 99.343% when pulling 1110293 on issue-533 into eb11776 on master.

@joejordanbrown
Copy link

@jbottigliero

Just faced this issue.

Is there a reason why this wasn't merged?

…iles` when no `bumpFiles` argument is specified (default).

- Merges `packageFiles` with `defaults.bumpFiles` before merging in arguments when a `packageFile` argument is present.
- Adds some simple "validation" to updaters and improves error messaging.
- Adds a test case covering #533

closes #533
@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2021

Codecov Report

Merging #534 (97af9a8) into master (a0bc835) will decrease coverage by 0.24%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #534      +/-   ##
==========================================
- Coverage   97.73%   97.49%   -0.25%     
==========================================
  Files          25       25              
  Lines        1106     1118      +12     
==========================================
+ Hits         1081     1090       +9     
- Misses         25       28       +3     
Impacted Files Coverage Δ
lib/updaters/index.js 77.14% <71.42%> (-7.24%) ⬇️
index.js 100.00% <100.00%> (ø)
test/core.spec.js 98.11% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0bc835...97af9a8. Read the comment docs.

@jbottigliero jbottigliero merged commit 2785023 into master Oct 19, 2021
@jbottigliero jbottigliero deleted the issue-533 branch October 19, 2021 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Question: Are packageFiles in .versionrc not bumped automatically?
4 participants