Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting info of a Chat with no members throws an error #103

Closed
mmacfadden opened this issue Apr 27, 2020 · 0 comments
Closed

Getting info of a Chat with no members throws an error #103

mmacfadden opened this issue Apr 27, 2020 · 0 comments
Assignees
Labels
bug Something isn't working client Issues related to the client
Milestone

Comments

@mmacfadden
Copy link
Contributor

Versions
Please fill in all that apply:

  • Convergence Version: 1.0.0-rc.5

Describe the Bug
When getting the chat info of a chat that has no members an error is thrown:

TypeError: Cannot read property 'map' of undefined
    at createChatInfo (convergence.esm.js:16379)
    at convergence.esm.js:16916
    at async onDomainConnect (user-utils.ts:37)

This occurs in the createChatInfo method because we are not checking for the protobuf default array value.

Step To Reproduce
A code snippet or gist to reproduce the issue will greatly improve our response time

  1. Create a chat channel called "general" with no members.
  2. From the client domain.chat().get("general");

Expected Behavior
This should return a chat object with no members.

@mmacfadden mmacfadden added bug Something isn't working client Issues related to the client labels Apr 27, 2020
@mmacfadden mmacfadden added this to the 1.0.0-rc.6 milestone Apr 27, 2020
@mmacfadden mmacfadden self-assigned this Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client Issues related to the client
Projects
None yet
Development

No branches or pull requests

1 participant