Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

References not disposed when model element is detached. #125

Closed
mmacfadden opened this issue May 15, 2020 · 0 comments
Closed

References not disposed when model element is detached. #125

mmacfadden opened this issue May 15, 2020 · 0 comments
Assignees
Labels
bug Something isn't working client Issues related to the client
Milestone

Comments

@mmacfadden
Copy link
Contributor

Versions

  • Convergence Version: 1.0.0-rc.5

Describe the Bug
When a model element is deleted, its corresponding references are not disposed.

Step To Reproduce

const realTimeString = model.get("somString");
const ref = realTimeString.indexReference();
realTimeString.removeFromParent();

console.log(ref.isDisposed()) // will return false, should return true.
@mmacfadden mmacfadden added bug Something isn't working client Issues related to the client labels May 15, 2020
@mmacfadden mmacfadden added this to the 1.0.0-rc.6 milestone May 15, 2020
@mmacfadden mmacfadden self-assigned this May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client Issues related to the client
Projects
None yet
Development

No branches or pull requests

1 participant