Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting model while offline throws an error #157

Closed
mmacfadden opened this issue Jul 2, 2020 · 0 comments
Closed

Deleting model while offline throws an error #157

mmacfadden opened this issue Jul 2, 2020 · 0 comments
Assignees
Labels
bug Something isn't working client Issues related to the client
Milestone

Comments

@mmacfadden
Copy link
Contributor

Versions
Please fill in all that apply:

Describe the Bug
When deleting a model offline, we properly delete the model in the offline store, but do not check if we are online or not, and then try to delete the model at the server which throws an exception.

main-app.js:114 TypeError: Cannot read property 'request' of undefined
    at ConvergenceConnection.request (ConvergenceConnection.ts:217)
    at ModelService._removeOnline (ModelService.ts:1216)
    at ModelService.<anonymous> (ModelService.ts:595)
    at Generator.next (<anonymous>)
    at fulfilled (OfflineModelSyncCompletedEvent.ts:25)

We need to check if we are online before trying to call the server.

@mmacfadden mmacfadden added bug Something isn't working client Issues related to the client labels Jul 2, 2020
@mmacfadden mmacfadden added this to the 1.0.0-rc.7 milestone Jul 2, 2020
@mmacfadden mmacfadden self-assigned this Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client Issues related to the client
Projects
None yet
Development

No branches or pull requests

1 participant